Remove 'sign transaction' tab and page & update 'transaction/cli-sign' to use /import#2106
Conversation
jeesunikim
changed the title
/import
There was a problem hiding this comment.
Pull request overview
This PR removes the standalone “Sign transaction” page/route and consolidates entry points around the existing import-based transaction flow, including updating the Stellar CLI deep link adapter to land on /transaction/import. It also includes a small accessibility cleanup by removing redundant role="row" attributes from table rows.
Changes:
- Removed
/transaction/signUI (and nav links) and added a permanent redirect to/transaction/import - Added shared XDR parsing helper (
parseImportXdr) and reused it in the import step, including a deep-link parsing path - Updated Playwright coverage to target the import page instead of the removed sign page
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/signTransactionPage.test.ts | Removed e2e coverage for the deleted /transaction/sign page. |
| tests/e2e/signStepContent.test.ts | Updated expectations to match the new “Import transaction” heading in the flow. |
| tests/e2e/signerSelector.test.ts | Updated heading assertion to “Import transaction”. |
| tests/e2e/importTransactionPage.test.ts | Added e2e coverage for /transaction/import and step advancement. |
| tests/e2e/feeBumpPage.test.ts | Updated heading assertion to “Import transaction”. |
| src/helpers/parseImportXdr.ts | New shared helper to parse imported transaction envelope XDR into derived store fields. |
| src/constants/routes.ts | Removed SIGN_TRANSACTION route constant. |
| src/constants/navItems.tsx | Removed “Sign transaction” from the transaction nav. |
| src/components/DataTable/index.tsx | Removed redundant role=\"row\" from <tr>. |
| src/app/page.tsx | Updated intro link from “sign” to “import”. |
| src/app/(sidebar)/transaction/sign/page.tsx | Deleted the /transaction/sign page. |
| src/app/(sidebar)/transaction/sign/components/Overview.tsx | Deleted sign-page overview/signing implementation. |
| src/app/(sidebar)/transaction/sign/components/Import.tsx | Deleted sign-page import screen. |
| src/app/(sidebar)/transaction/import/components/ImportStepContent.tsx | Refactored parsing to use parseImportXdr and added deep-link parse behavior. |
| src/app/(sidebar)/transaction/dashboard/components/Signatures.tsx | Removed redundant role=\"row\" from <tr>. |
| src/app/(sidebar)/transaction/components/Signatures.tsx | Removed redundant role=\"row\" from <tr>. |
| src/app/(sidebar)/transaction/cli-sign/page.tsx | Reworked CLI deep link to seed import-flow store and redirect to import page. |
| next.config.js | Added permanent redirect from /transaction/sign to /transaction/import. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Preview is available here: |
|
Preview is available here: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10cfb5231a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
jeesunikim
force-pushed
the
remove-sign-tx
branch
from
10cfb52 to
a9ccdee
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9ccdeeff6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Preview is available here: |
|
Preview is available here: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ec6001d2e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Preview is available here: |
|
Preview is available here: |
|
Preview is available here: |
|
Preview is available here: |
Summary:
reroute
transaction/signtotransaction/import/cli-signto reroute totransaction/importand parse the xdr correctlyremove
role="rowfrom<tr/>/cli-signexample:update-cli-sign.mov