SPIKE: Protocol 28 (CAP-0084)#2141
Draft
sisuresh wants to merge 1 commit into
Draft
Conversation
|
Preview is available here: |
This was referenced Jul 3, 2026
Author
This was referenced Jul 3, 2026
Lab decodes XDR data-driven via @stellar/stellar-sdk + @stellar/stellar-xdr-json; SC_ADDRESS_TYPE_MUXED_CONTRACT renders with no lab source change once those deps carry CAP-0084. Pins @stellar/stellar-sdk (js-stellar-sdk#1507) and @stellar/stellar-xdr-json (js-stellar-xdr-json#59) to local CAP-0084 tarballs under .p28-tarballs via file: refs. js-stellar-sdk@16 now vendors stellar-base internally, so no separate @stellar/stellar-base tarball/override is needed (the only base@15 in the tree is the unrelated Trezor chain, off the tx-render path). The @ts-expect-error in TransactionDetails.tsx is kept — the new types still don't expose innerTx() on the fee-bump path (tsc TS2339 without it). pnpm build + lint:ts + lint + test:unit all pass with the pins in place. Adds NEXT_PUBLIC_CUSTOM_{HORIZON_URL,RPC_URL,PASSPHRASE} fallbacks to defaultCustomNetwork for the Quickstart-bundled lab.
|
Preview is available here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPIKE: Protocol 28 (CAP-0084) — Muxed Contract Addresses.
Lab decodes XDR data-driven via
@stellar/stellar-sdk+@stellar/stellar-xdr-json;SC_ADDRESS_TYPE_MUXED_CONTRACTrenders with no lab source change once those deps carry CAP-0084.Changes
@stellar/stellar-sdkand@stellar/stellar-xdr-jsonto local CAP-0084 tarballs (.p28-tarballs/,file:refs) built from the upstream PRs below. Verified:pnpm build,lint:ts,lint,test:unitall pass.js-stellar-sdk@16vendors stellar-base internally, so no separate@stellar/stellar-basetarball/override is needed (the onlybase@15in the tree is the unrelated Trezor chain, off the tx-render path — plan's base-override step dropped as unnecessary).@ts-expect-errorinTransactionDetails.tsx— new types still don't exposeinnerTx()on the fee-bump path (tsc TS2339 without it).NEXT_PUBLIC_CUSTOM_{HORIZON_URL,RPC_URL,PASSPHRASE}fallbacks todefaultCustomNetworkfor the Quickstart-bundled lab.Deferred
file:tarball pins for published versions once upstream releases; drop.p28-tarballs/.federation/server.js)require()s ESM-only@noble/hashes@2.2.0/sha2.js, so Playwright e2e collection fails under Node CJS (ERR_REQUIRE_ESM). Next.js prod build (ESM/webpack) and jest unit tests are unaffected. Resolves when upstream sdk ships a CJS-safe@noble/hashesinterop / published release. PR stays draft until then.Upstream (CAP-0084 chain, unmerged/unpublished)
stellar/js-stellar-base#981 · stellar/js-stellar-sdk#1507 · stellar/js-stellar-xdr-json#59 · stellar/stellar-xdr#307 · stellar/rs-stellar-xdr#552 · stellar/rs-soroban-env#1700 · stellar/rs-soroban-sdk#1924 · stellar/stellar-core#5337 · stellar/go-stellar-sdk#5961 · stellar/stellar-horizon#203 · stellar/stellar-rpc#837 · stellar/quickstart#950