Skip to content

Add configurable container runtime variable to Makefile#893

Merged
leighmcculloch merged 5 commits intomainfrom
container-runtime
Feb 12, 2026
Merged

Add configurable container runtime variable to Makefile#893
leighmcculloch merged 5 commits intomainfrom
container-runtime

Conversation

@leighmcculloch
Copy link
Member

What

Introduce a CONTAINER_RUNTIME variable that defaults to docker but can be overridden to use alternative runtimes like podman. Replace hardcoded docker commands in run, logs, console, and build targets with this variable.

Why

Allow users with different container runtimes to use the Makefile without modification.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds flexibility to the Makefile by introducing a configurable container runtime variable, allowing users to use alternative container runtimes like Podman without modifying the Makefile.

Changes:

  • Added CONTAINER_RUNTIME variable with conditional assignment defaulting to docker
  • Replaced all hardcoded docker commands in the Makefile with the $(CONTAINER_RUNTIME) variable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leighmcculloch leighmcculloch marked this pull request as ready for review January 30, 2026 05:34
@leighmcculloch leighmcculloch requested a review from a team January 30, 2026 05:34
@leighmcculloch leighmcculloch enabled auto-merge (squash) February 12, 2026 10:48
Copy link
Member

@fnando fnando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! There are 2 actions failing, related to friendbot timing out, but that's also happening on main (curiously, both failures happen on arm64) Re-running failed jobs made them pass!

@leighmcculloch leighmcculloch merged commit da350e3 into main Feb 12, 2026
174 of 178 checks passed
@leighmcculloch leighmcculloch deleted the container-runtime branch February 12, 2026 20:00
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants