Skip to content

overlay-only loadgen mode updates: checkValid cleanup and new tx profiles#5243

Merged
marta-lokhova merged 3 commits intostellar:masterfrom
marta-lokhova:overlayOnlyModeCleanup
Apr 27, 2026
Merged

overlay-only loadgen mode updates: checkValid cleanup and new tx profiles#5243
marta-lokhova merged 3 commits intostellar:masterfrom
marta-lokhova:overlayOnlyModeCleanup

Conversation

@marta-lokhova
Copy link
Copy Markdown
Contributor

No description provided.

@marta-lokhova marta-lokhova force-pushed the overlayOnlyModeCleanup branch from fbe7f77 to b9ea7b0 Compare April 23, 2026 18:08
@marta-lokhova marta-lokhova changed the title Overlay only mode cleanup overlay-only loadgen mode updates: checkValid cleanup and new tx profiles Apr 23, 2026
@marta-lokhova marta-lokhova marked this pull request as ready for review April 23, 2026 23:05
Copilot AI review requested due to automatic review settings April 23, 2026 23:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Stellar Core’s overlay-only load generator behavior to run deeper end-to-end validation (including Soroban resource checks) and introduces new mixed classic+pregen + synthetic Soroban load profiles for exercising overlay throughput without on-ledger contract setup.

Changes:

  • Remove the overlay-only checkValid short-circuit and add an overlay-only test-only mechanism to skip seqnum equality checks during validation.
  • Add new MIXED_PREGEN_* loadgen modes, including synthetic Soroban transaction generation (SAC payment, OZ token transfer, Soroswap swap) alongside pre-generated classic payments.
  • Refactor Soroswap swap tx construction into TxGenerator and improve overlay-only apply logging and tx-set validation behavior in tests.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/transactions/TransactionFrame.cpp Removes overlay-only checkValid bypass; adds conditional seqnum check skip via ledger-view wrapper flag.
src/ledger/ImmutableLedgerView.h Adds test-only mSkipSeqNumCheck flag to support overlay-only validation.
src/herder/TransactionQueue.cpp Sets mSkipSeqNumCheck in overlay-only; adjusts fee-check gating for test builds.
src/herder/TxSetUtils.cpp Sets mSkipSeqNumCheck for tx-set validation in overlay-only.
src/herder/TxSetFrame.cpp Disables unique-source enforcement in overlay-only (test-only).
src/herder/HerderImpl.cpp Disables 1-tx-per-source cross-queue limit in overlay-only (test-only).
src/simulation/LoadGenerator.h / .cpp Adds MIXED_PREGEN modes, synthetic Soroban tx creation, and per-stream accounting for completion.
src/simulation/TxGenerator.h / .cpp Adds synthetic contract/state builders and a Soroswap swap tx builder; centralizes key helpers.
src/simulation/ApplyLoad.h / .cpp Reuses TxGenerator’s Soroswap state/types and swap builder.
src/simulation/test/LoadGeneratorTests.cpp Updates overlay-only test config limits and adds mixed-mode test coverage.
src/main/CommandHandler.cpp Adds CLI params for MIXED_PREGEN per-stream TPS and sets combined txRate.
src/ledger/LedgerManagerImpl.cpp Improves overlay-only “skipping apply” log with classic/soroban breakdown.

Comment thread src/simulation/LoadGenerator.cpp Outdated
Comment thread src/simulation/LoadGenerator.cpp
Comment thread src/simulation/LoadGenerator.cpp
Comment thread src/main/CommandHandler.cpp
@marta-lokhova marta-lokhova force-pushed the overlayOnlyModeCleanup branch from 39148ea to c4f884b Compare April 27, 2026 17:52
dmkozh
dmkozh previously approved these changes Apr 27, 2026
Comment thread src/transactions/TransactionFrame.cpp Outdated
@marta-lokhova marta-lokhova enabled auto-merge April 27, 2026 20:34
@marta-lokhova marta-lokhova added this pull request to the merge queue Apr 27, 2026
Merged via the queue into stellar:master with commit babc566 Apr 27, 2026
50 of 53 checks passed
@marta-lokhova marta-lokhova deleted the overlayOnlyModeCleanup branch April 27, 2026 22:19
@marta-lokhova marta-lokhova self-assigned this Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants