📝 Remove trailing backslashes from embed links#2396
Closed
JFWooten4 wants to merge 5 commits intostellar:mainfrom
Closed
📝 Remove trailing backslashes from embed links#2396JFWooten4 wants to merge 5 commits intostellar:mainfrom
JFWooten4 wants to merge 5 commits intostellar:mainfrom
Conversation
JFWooten4
added a commit
to JFWooten4/stellar-docs
that referenced
this pull request
Apr 26, 2026
Contributor
Author
|
I accidentally put de3c970 and 3f0f080 images on this branch. They were migrated to a proper diagram PR in #2400. It looks like the relevant commits were taken into #2409, and we can leave that as the merge for this principal fix. Closing in favor of Bri's version, which maintains proper scope and removes unnecessary i18n Spanish changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a lot of links right now that unnecessarily end with a trailing
/before the closing).1 These double punctuation marks create an unpleasant interruption in line edits and copy scans. For instance, ten API pages across twoymls say:They go on to use JSON commas, strKeys in quotes, and curly brackets to encode documentation. If you look through that quickly and get distracted by all the fancy punctuation, you could easily miss the blatant "tio" typo in the middle of the sentence. Thus, we can simplify the review process by cleaning up these old, dirty formats so that new contributions can stand beautifully on their own.
Also, the terminal backslashes visually break up already messy markdown tables without additional spacing, like in
docs/data/analytics/analytics-providers/analytics-providers.mdx. It's very hard to proofread these big text blobs already, and the extra symbols just make it even more difficult to identify pipes that are only space-delineated. By simplifying the imports in the embeds, it should be a lot easier to clearly improve graphed chart data going forward.Footnotes
The vast majority of links changed are origin-only URLs with equivalent browser treatment between empty and terminated paths. ↩