⚙️ Site build config for compatibility#2402
Open
JFWooten4 wants to merge 11 commits intostellar:mainfrom
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the docs site build tooling/config to improve cross-system compatibility by adjusting the build command’s Node memory settings, adding cross-env, and ensuring VS Code uses the workspace TypeScript version.
Changes:
- Updated the
buildscript to run Docusaurus with an increased Node heap limit. - Added
cross-env(and correspondingyarn.lockentries). - Added a VS Code workspace setting to point to the repo’s TypeScript SDK.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
package.json |
Changes build invocation and adds cross-env to devDependencies. |
yarn.lock |
Locks cross-env and its new transitive dependency. |
.vscode/settings.json |
Adds a workspace TypeScript SDK path for VS Code. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
as intended Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been grappling with this for years now, and I'm finally proposing we add
cross-env. There's just a lot of cool things we can optimize with this between systems.As you add more meetings over time, the build size compounds with the new pages. It's still very reasonable linear building, but you hit the max compile chunk after about a hundred or so.
This little fix gives the compiler some more memory, or at least the preview history. It's nothing fancy, but it stops heap mallocs.
Lastly, I ran into a problem where TypeScript ran with the wrong version based on complaints of global settings. This little VS Code config makes sure it uses the version for the project.