🕷️ Patch tracking element load failure#2417
Open
JFWooten4 wants to merge 1 commit intostellar:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes Docusaurus’ Google gtag page-view tracking resilient to cases where window.gtag is blocked or not yet loaded (e.g., ad blockers / interrupted GTM), preventing runtime errors during navigation.
Changes:
- Adds a runtime guard to return early when
window.gtagis not a function before sendingpage_view.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docusaurus does not have a good time right now where there are interruptions between it and the Google Tag Manager. This PR stops the following recurring error (scales with page reloads when it happens):
Changes
Adds a runtime guard around Docusaurus’ Google gtag page-view tracking callback. It is often blocked by an ad blocker, delayed, or not loaded yet, that call can crash.
Previously, the plugin assumed
window.gtagwas always available before sending thepage_viewevent. This patch returns early whenwindow.gtagis not a function, preventing runtime errors in environments where the analytics script is unavailable.The intent is to keep analytics optional and non-blocking, so page navigation continues safely even when Google tracking cannot run. Hence the page-view guard.