🐜 Patch react-loadable SSR URL resolution#2418
Open
JFWooten4 wants to merge 1 commit intostellar:mainfrom
Open
🐜 Patch react-loadable SSR URL resolution#2418JFWooten4 wants to merge 1 commit intostellar:mainfrom
JFWooten4 wants to merge 1 commit intostellar:mainfrom
Conversation
Replace the package use of Node legacy url.resolve with a WHATWG URL-based resolver so Docusaurus builds on Node 24 no longer emit the DEP0169 url.parse deprecation warning. Keep relative, absolute-path, and absolute-URL publicPath behavior aligned with the legacy resolver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This little error popped up during my latest
yarn build. Looks like the legacy Node variant didn't carry over to the v24 upgrade, so we will move on with this direct implementation. This gives us more space to implement needed linking logic; resolver warning fixed:Changes
Replaces the package use of Node’s legacy
url.resolvewith a WHATWGURL-based resolver. The patch updates both the compiled library output and the source file included in the package.This prevents Docusaurus builds on Node 24 from emitting the
DEP0169url.parsedeprecation warning while preserving the expected public path behavior for relative paths, absolute paths, and absolute URLs.Now that this is taken care of, I'd like to work on direct API page links for only the dev site. We can implement a post-build migrator along the lines of this PR, which inlines otherwise external links for import package managers.