Skip to content

Improve error messages when flag values are mistaken for mission names #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Improve error messages when flag values are mistaken for mission names #374

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
000b489
Initial plan
Copilot Apr 16, 2026
cdea32b
Improve error messages when flag values are mistaken for mission names
Copilot Apr 16, 2026
2a1cb7d
Address code review feedback: rename variable and use specific exampl…
Copilot Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/App/Program.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,9 +754,26 @@ let main argv =
{ LogDebugPartitions = List.ofSeq mission.LogDebugPartitions
LogTracePartitions = List.ofSeq mission.LogTracePartitions }

let looksLikeFlagValue (s: string) =
match s.ToLowerInvariant() with
| "true" | "false" -> true
| _ ->
let (isNumeric, _) = System.Double.TryParse(s)
isNumeric

match Seq.tryFind (allMissions.ContainsKey >> not) mission.Missions with
| Some e ->
(LogError "Unknown mission: %s" e

if looksLikeFlagValue e then
LogError
"Note: '%s' looks like a value for a command-line flag rather than a mission name. You may have passed an argument to a flag that doesn't accept one (e.g. --catchup-skip-known-results-for-testing=false instead of --catchup-skip-known-results-for-testing)."
e
elif e.StartsWith("-") then
LogError
"Note: '%s' looks like a command-line option rather than a mission name. You may have a typo in the option name, or used an option not supported by the 'mission' verb."
e

LogError "Available missions:"
Map.iter (fun k _ -> LogError " %s" k) allMissions
1)
Expand Down
Loading