Bugfix: use p75 for min block test as per eval doc#378
Merged
marta-lokhova merged 1 commit intostellar:mainfrom Apr 23, 2026
Merged
Bugfix: use p75 for min block test as per eval doc#378marta-lokhova merged 1 commit intostellar:mainfrom
marta-lokhova merged 1 commit intostellar:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the minimum-block-time mission SLA evaluation to use the 75th percentile (P75) for ledger.age.closed-histogram, aligning implementation and documentation with the evaluation guidance.
Changes:
- Switch SLA percentile check from P50/median to P75 in
MinBlockTimeTest. - Update mission/module comments and documentation to reflect P75-based SLA.
- Adjust log output labels from
p50top75.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/FSLibrary/MissionMinBlockTimeClassic.fs | Updates mission header comment to describe P75-based SLA (note: range comment still mentions 6000). |
| src/FSLibrary/MinBlockTimeTest.fs | Uses P75 (instead of median) when evaluating per-peer ledger age SLA and updates logging text accordingly. |
| doc/missions.md | Updates MissionMinBlockTimeClassic description to P75-based SLA. |
| doc/measuring-minimum-block-time.md | Updates SLA definition and FIXME note from P50 to P75. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dmkozh
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.