Skip to content

Add support for ignoring time bounds for block time validation#379

Merged
marta-lokhova merged 1 commit intostellar:mainfrom
marta-lokhova:ignoreTime
Apr 27, 2026
Merged

Add support for ignoring time bounds for block time validation#379
marta-lokhova merged 1 commit intostellar:mainfrom
marta-lokhova:ignoreTime

Conversation

@marta-lokhova
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a mission-level toggle to have generated stellar-core configs ignore ledger time upgrade bounds, intended to support MinBlockTime missions that repeatedly adjust ledger close timing.

Changes:

  • Extend MissionContext with a runForMinBlockTime flag.
  • When runForMinBlockTime is set, emit TESTING_IGNORE_LEDGER_TIME_UPGRADE_BOUNDS = true into generated stellar-core TOML.
  • Set the flag within MinBlockTimeTest; update app/test record initializations to include the new field.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/FSLibrary/StellarMissionContext.fs Adds runForMinBlockTime to the shared mission context record.
src/FSLibrary/StellarCoreCfg.fs Conditionally writes TESTING_IGNORE_LEDGER_TIME_UPGRADE_BOUNDS into TOML based on mission context.
src/FSLibrary/MinBlockTimeTest.fs Sets runForMinBlockTime = true for MinBlockTime runs.
src/FSLibrary.Tests/Tests.fs Updates test MissionContext record initialization with the new field.
src/App/Program.fs Updates CLI-created MissionContext initializations with the new field.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/FSLibrary/StellarMissionContext.fs
Comment thread src/FSLibrary/StellarCoreCfg.fs
@marta-lokhova marta-lokhova merged commit 14a21b3 into stellar:main Apr 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants