Add support for ignoring time bounds for block time validation#379
Merged
marta-lokhova merged 1 commit intostellar:mainfrom Apr 27, 2026
Merged
Add support for ignoring time bounds for block time validation#379marta-lokhova merged 1 commit intostellar:mainfrom
marta-lokhova merged 1 commit intostellar:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a mission-level toggle to have generated stellar-core configs ignore ledger time upgrade bounds, intended to support MinBlockTime missions that repeatedly adjust ledger close timing.
Changes:
- Extend
MissionContextwith arunForMinBlockTimeflag. - When
runForMinBlockTimeis set, emitTESTING_IGNORE_LEDGER_TIME_UPGRADE_BOUNDS = trueinto generated stellar-core TOML. - Set the flag within
MinBlockTimeTest; update app/test record initializations to include the new field.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/FSLibrary/StellarMissionContext.fs |
Adds runForMinBlockTime to the shared mission context record. |
src/FSLibrary/StellarCoreCfg.fs |
Conditionally writes TESTING_IGNORE_LEDGER_TIME_UPGRADE_BOUNDS into TOML based on mission context. |
src/FSLibrary/MinBlockTimeTest.fs |
Sets runForMinBlockTime = true for MinBlockTime runs. |
src/FSLibrary.Tests/Tests.fs |
Updates test MissionContext record initialization with the new field. |
src/App/Program.fs |
Updates CLI-created MissionContext initializations with the new field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dmkozh
approved these changes
Apr 24, 2026
b6a9b81 to
4c24a8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.