Split load across nodes more evenly, useful for low tps configs#383
Open
marta-lokhova wants to merge 1 commit intostellar:mainfrom
Open
Split load across nodes more evenly, useful for low tps configs#383marta-lokhova wants to merge 1 commit intostellar:mainfrom
marta-lokhova wants to merge 1 commit intostellar:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how RunMultiLoadgen splits per-node loadgen settings so that “remainder” TPS (and related mixed-mode rates) is distributed across the first r nodes instead of being concentrated on a single node. This better balances per-node load in low-TPS configurations, especially when total TPS is smaller than the number of loadgen nodes.
Changes:
- Change integer-splitting logic to distribute
attr % nacross the firstrnodes (instead of putting all remainder on the last node). - For mixed pregen modes, derive per-node
txratefrom the per-nodeclassicTxRate/sorobanTxRateshares to keep the three rate fields consistent on each peer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had this issue for a while, but this is a lot more relevant now that we're testing Soroban loads where tps is generally quite a bit lower than classic. the change spread the load more evenly across nodes