Skip to content

Split load across nodes more evenly, useful for low tps configs#383

Open
marta-lokhova wants to merge 1 commit intostellar:mainfrom
marta-lokhova:loadgenSplit
Open

Split load across nodes more evenly, useful for low tps configs#383
marta-lokhova wants to merge 1 commit intostellar:mainfrom
marta-lokhova:loadgenSplit

Conversation

@marta-lokhova
Copy link
Copy Markdown
Contributor

We've had this issue for a while, but this is a lot more relevant now that we're testing Soroban loads where tps is generally quite a bit lower than classic. the change spread the load more evenly across nodes

Copilot AI review requested due to automatic review settings April 29, 2026 23:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts how RunMultiLoadgen splits per-node loadgen settings so that “remainder” TPS (and related mixed-mode rates) is distributed across the first r nodes instead of being concentrated on a single node. This better balances per-node load in low-TPS configurations, especially when total TPS is smaller than the number of loadgen nodes.

Changes:

  • Change integer-splitting logic to distribute attr % n across the first r nodes (instead of putting all remainder on the last node).
  • For mixed pregen modes, derive per-node txrate from the per-node classicTxRate/sorobanTxRate shares to keep the three rate fields consistent on each peer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants