Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Release v3.0.0 updating the monorepo packages for Stellar Protocol 26 support, including SDK dependency upgrades and Freighter integration updates.
Changes:
- Bump
@stellar/stellar-sdkto15.0.1across all packages and update related transitive deps inyarn.lock. - Upgrade
@stellar/freighter-apito^6.0.1and rewrite the Freighter handler to use the v6signTransactionAPI + correct network passphrase for XDR parsing. - Add new Freighter handler tests and add Soroban XDR integer boundary tests; adjust a SEP-24 paging-id integration test expectation.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Locks upgraded Stellar SDK, Freighter API, and transitive dependency versions. |
| @stellar/typescript-wallet-sdk/test/wallet.test.ts | Updates SEP-24 pagingId test to reflect anchor server rejecting invalid IDs. |
| @stellar/typescript-wallet-sdk/package.json | Bumps package to 3.0.0 and upgrades @stellar/stellar-sdk to 15.0.1. |
| @stellar/typescript-wallet-sdk/CHANGELOG.MD | Adds 3.0.0 release notes and breaking-change notes. |
| @stellar/typescript-wallet-sdk-soroban/test/helpers.test.ts | Adds XDR integer boundary/overflow-related tests for Protocol 26. |
| @stellar/typescript-wallet-sdk-soroban/package.json | Bumps package to 3.0.0 and upgrades @stellar/stellar-sdk to 15.0.1. |
| @stellar/typescript-wallet-sdk-soroban/CHANGELOG.MD | Adds 3.0.0 release notes including new boundary tests. |
| @stellar/typescript-wallet-sdk-km/test/freighter.test.ts | Adds initial unit test coverage for the Freighter handler under freighter-api v6. |
| @stellar/typescript-wallet-sdk-km/src/Handlers/freighter.ts | Reworks signing flow for freighter-api v6; fixes network passphrase used for XDR deserialization and improves error handling. |
| @stellar/typescript-wallet-sdk-km/package.json | Bumps package to 3.0.0; upgrades @stellar/freighter-api and @stellar/stellar-sdk. |
| @stellar/typescript-wallet-sdk-km/CHANGELOG.MD | Adds 3.0.0 release notes, including Freighter handler breaking change and fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
piyalbasu
left a comment
There was a problem hiding this comment.
This PR is lgtm and the Claude code review came back good. I just left 1 very nit comment
…o 3.0.0 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…assphrase bug Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…etails Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Re-throw Error instances in freighter handler catch block instead of double-wrapping - Add test for custom.address passthrough to freighter API - Remove incorrect changelog claims about XDR integer overflow throwing - Remove overflow/underflow tests that documented non-existent behavior Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix misleading error message in freighter handler ("ledger handler" -> "Freighter handler")
- Remove unnecessary JSON.stringify on publicKey string
- Use true i64/u64 boundary values in XDR tests via Int64.fromString/Uint64.fromString
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…n layers i64/u64 throw at fromString(), i32/u32 throw at toXDR() serialization. Update changelogs with accurate description. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…elogs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
FYI, I had to re-create the commit history on this PR because the original commits were missing a |
Summary
@stellar/stellar-sdkfrom14.5.0to15.0.1across all 3 packages — Protocol 26 support@stellar/freighter-apifrom^2.0.0to^6.0.1in the key manager packageNetworks.PUBLICfor XDR deserialization regardless of actual networksignTransactionsignature and response shape)Breaking Changes
All packages
@stellar/stellar-sdkupgraded from14.5.0to15.0.1(Protocol 26 XDR)TransactionBase.networkPassphrasesetter now throws to enforce immutability (upstream)Key Manager (
@stellar/typescript-wallet-sdk-km)@stellar/freighter-apiupgraded from^2.0.0to^6.0.1custom.networkparam replaced withcustom.networkPassphraseTest plan
yarn build— all 3 packages compile successfullyyarn lint— zero warningsyarn test:ci— 244 passed, 4 skipped, 0 failed🤖 Generated with Claude Code