Fix Cache Reference Error in feeEstimate.js#390
Merged
Conversation
|
@Gainer-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a cache reference error in
src/routes/feeEstimate.jswhere the cache service is imported ascacheServicebut referenced ascachewithin the route handler. This mismatch results in aReferenceErrorwhenever cached responses are accessed, preventing the caching layer from functioning correctly.Changes
cache.get(...)calls withcacheService.get(...).cache.set(...)calls withcacheService.set(...)./fee-estimateroute.Why
The incorrect cache reference caused every request that relied on the cache to fail with a
ReferenceError, effectively disabling the caching mechanism. This fix restores the intended behavior, improving reliability and performance.Testing
GET /fee-estimatereturns a successful response without throwing aReferenceError.X-Cache: HITheader.Checklist
closes #245
closes #246
closes #247
closes #248