Skip to content

feat: add ?order param to /account/:id/payments and fix errorHandler …#404

Merged
Sulex45 merged 1 commit into
stellarkit-lab-devtools:mainfrom
Iyrah:feat/payments-order-param
Jun 28, 2026
Merged

feat: add ?order param to /account/:id/payments and fix errorHandler …#404
Sulex45 merged 1 commit into
stellarkit-lab-devtools:mainfrom
Iyrah:feat/payments-order-param

Conversation

@Iyrah

@Iyrah Iyrah commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

…syntax

  • ?order=asc|desc is validated via existing validateOrder helper
  • Invalid order values return 400 ValidationError
  • Default order is desc when omitted
  • Add tests covering asc, desc, default, and invalid order values
  • Fix broken Horizon error block in errorHandler.js (dead return + undeclared body)

Closes #348

…syntax

- ?order=asc|desc is validated via existing validateOrder helper
- Invalid order values return 400 ValidationError
- Default order is desc when omitted
- Add tests covering asc, desc, default, and invalid order values
- Fix broken Horizon error block in errorHandler.js (dead return + undeclared body)

Closes stellarkit-lab-devtools#348
@drips-wave

drips-wave Bot commented Jun 28, 2026

Copy link
Copy Markdown

@Iyrah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Sulex45 Sulex45 merged commit af46eac into stellarkit-lab-devtools:main Jun 28, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Developer Experience | Add ?order=asc|desc support to GET /account/:id/payments

2 participants