feat(session): expose maxOutputTokens on llm adapters#63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxOutputTokens?: numbertoAnthropicAdapterOptionsandOpenAICompatibleOptionsso consumers can configure the per-request output cap once at adapter creation timemax_tokens:completeOptions.maxTokens(per-call override) >options.maxOutputTokens(adapter default) >4096(built-in safety net) — preserves existing behaviour when neither is setWhy
Both adapters previously hard-coded
?? 4096for the requestmax_tokens. This is too low for non-trivial outputs: long tool-call argument JSONs (e.g. multi-item results) and long synthesis/integration outputs hit the cap and get truncated. The downstream parsers then throw on the unterminated JSON. Without a way for embedders to raise the cap at adapter level, every consumer had to either patch the source or passmaxTokenson every single call site.Note: Anthropic's
messages.createAPI requiresmax_tokens, so the adapter must always send a value —maxOutputTokensonly adjusts which value is sent, not whether one is sent.Test plan
options.maxOutputTokens/completeOptions.maxTokenswins)