Video: Camera and MAVLink Improvements (Draft)#403
Draft
ddd999 wants to merge 1 commit into
Draft
Conversation
Improvements to the MAVLink Camera subsystem: * Force MavLinkV2 for messages with ID > 255 * Handle additional MavLink camera commands * Fixes issue where geotagging worked when the camera was triggered in the web UI but not when triggered via MavLink * Add/update unit tests for better coverage * Add CameraImageCaptured message * Camera now sends a heartbeat immediately instead of waiting for the first interval timer * Performance improvements to get_camera_caps.py: reduce run time on Pi Zero 2W from 13-19s <1s by eliminating unnecessary libcamera calls * Minor bugfixes/cleanup
Author
|
Running the code in this branch connected to an SITL simulated vehicle, I was able to run a simulated survey mission in QGroundControl and have Rpanion capturing photos as per the flight plan. No config in QGC required, it just auto-recognized everything once CAM1_TYPE was set to MavLinkV2 in the vehicle parameters. In streaming mode, QGC auto-discovers the stream and displays it when available. There are still a few oddities I've found when testing with QGC:
I didn't get as far testing with Mission Planner, QGC seemed to work better for whatever reason. Some of this might be related to how commands are being Ack'd, which might be partially fixed by the upstream commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following improvements to the MAVLink subsystem for camera control. Goal is to resolve #396 and add some additional enhancements/fixes.
TODO still:
* Also need to do some more testing of video mode errors.Done* Add photo/video mode switching via MavLinkDefer to future PR - not mission critical