Skip to content

Parser updates#19

Merged
stevearc merged 21 commits into
stevearc:masterfrom
dougVanny:parser_update
Feb 23, 2026
Merged

Parser updates#19
stevearc merged 21 commits into
stevearc:masterfrom
dougVanny:parser_update

Conversation

@dougVanny

@dougVanny dougVanny commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

This PR contains a series of changes to bring this parser up to date with new additions made to Godot (up to 4.6)

@dougVanny

Copy link
Copy Markdown
Contributor Author
  • On top of the new test cases I added, I also tested this change on my current game project, which currently has over 1400 tscn and tres files and is running on Godot 4.6. All files were parsed correctly, but the way how strings are stores in those files change from version to version, so test_parse_files.py still catches a few differences

  • Adding the changes made on test_parse_files.py updates #21 makes 99% of the files tested pass as virtually identical, with only a few weird string cases still failing

  • Adding the changes made on String output matching Godot 4.6 behavior #20 takes care of all those issues, and all files are then parsed and output correctly, without any differences detected by test_parse_files.py

@stevearc stevearc left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this, but please ensure that the tests and CI are passing first

@dougVanny

Copy link
Copy Markdown
Contributor Author

I'm happy to merge this, but please ensure that the tests and CI are passing first

Working on those fixes. I'll let you know as soon as they're ready. The tests pass when I run them locally so I'm relying on the github workflows to test my changes

* Fix 2

* Update formatting

* Formatting fix 2

* More formatting

* Fixes 100%

---------

Co-authored-by: DougVanny <douglas.vanny@proton.me>
@dougVanny

Copy link
Copy Markdown
Contributor Author

@stevearc Should be good to go now

@dougVanny

Copy link
Copy Markdown
Contributor Author

Or not. I'll take a look at the coverage checks. That check didn't run on my fork for some reason

@stevearc

Copy link
Copy Markdown
Owner

Awesome, thanks for the PR!

@stevearc stevearc merged commit 4aec5d3 into stevearc:master Feb 23, 2026
5 of 6 checks passed
@dougVanny dougVanny deleted the parser_update branch March 1, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants