(Towards #3398) move LFRicRedundantComputationTrans and update to use kwargs.

[arporter]

An initial step before updating the options accepted by this transformation.

[arporter]

Test failure is the treesitter one that #3408 fixes.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (8271184) to head (d8050ab).

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #3417   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          392       393    +1     
  Lines        54903     54918   +15     
=========================================
+ Hits         54903     54918   +15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[arporter]

A fairly straightforward PR that just moves LFRicRedundantComputationTrans to the correct location and updates it to use kwargs. One for @LonelyCat124 @sergisiso or @hiker.

[sergisiso]

@arporter @LonelyCat124 I have the new branches that force push to our lfric_apps almost ready, let me do the change and give you a hash to try, otherwise it will conflict with my changes. I will look at this tomorrow.

[arporter]

OK, thanks Sergi.

[sergisiso]

@arporter Updating the LFRic hash to 300225d72ffca5c843cdeceeedb353f6eb01dfa9 should work, but you need to bring the branch to master first.

PS: Another branch is already bringing this update, so not hash update should be necessary once this is brought to master

[arporter]

The NEMO integration test fails. This requires further investigation.

[arporter]

The problem was a circular dep. on Transformation in psyclone.utils which was only triggered if Sphinx wasn't installed (which meant we used our own implementation of the Sphinx-supplied method in utils.py).

[arporter]

Assuming the ITs are all fine, this is ready for another look now. (I cancelled the compilation IT because it would have failed due to a test failure that I've subsequently fixed.)

[LonelyCat124]

All looks good now, will being merging process.