(Closes #3435) Metatrans docs#3438
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3438 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 392 392
Lines 54791 54903 +112
==========================================
+ Hits 54791 54903 +112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sergisiso This should be ready for a first look now. Also let me know if you're happy with all the behaviour shown in |
sergisiso
left a comment
There was a problem hiding this comment.
I am happy with the behaviour @LonelyCat124, but the implementation is a bit hard to follow, specially the utils.py could benefit with more clear typehints and docstrings.
|
@sergisiso Ready for another look, most comments addressed, a couple I've just responded to with comments/questions for this review cycle. |
sergisiso
left a comment
There was a problem hiding this comment.
@LonelyCat124 This is approved for merging, I end up doing the final suggestions myself since only involved comments and formatting, but let me know if you disagree with anything.
This is the initial stage to have support for docs from _SUB_TRANSFORMATIONS supported.
There are remaining issues to fix:
MaximalOMPParallelRegionTransinherits thenode_type_checkfromRegionTrans, but then also finds it imported from itsSUB_TRANSFORMATIONclass. @sergisiso Do you think I should avoid repeated docstrings? Should it be limited in some way to only be if the strings are==? I think I can do that check (as the "Option used for ...") is added later.