Skip to content

(closes #3250) 100% coverage#3447

Merged
sergisiso merged 6 commits into
masterfrom
martin_coverage
Jun 1, 2026
Merged

(closes #3250) 100% coverage#3447
sergisiso merged 6 commits into
masterfrom
martin_coverage

Conversation

@schreiberx

Copy link
Copy Markdown
Collaborator

For 100% coverage.

Warning: This is AI generated.

@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5f5004c) to head (56c7310).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #3447      +/-   ##
===========================================
+ Coverage   99.96%   100.00%   +0.03%     
===========================================
  Files         391       392       +1     
  Lines       54689     54765      +76     
===========================================
+ Hits        54670     54765      +95     
+ Misses         19         0      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso

Copy link
Copy Markdown
Collaborator

@schreiberx There is 1 line missing, can we cover that one?
image

It is an odd one because it is a pytest fixture and has a no_cover (which apparently doesn't work)
image

I will attempt fixing it chaning the nocover, because this is tested in the compilation integration test, but not on the CI one that Codecov uses.

@sergisiso sergisiso changed the title 100% coverage (closes #3250) 100% coverage Jun 1, 2026

@sergisiso sergisiso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schreiberx Aha, the last one took a bit of trial and error but is finally 100%! This is approved for merging.

@sergisiso

Copy link
Copy Markdown
Collaborator

@schreiberx One more thing, in the future, instead of commit messages like "intermediate commit" could you write a more informative message, like "Requested Claude Code to cover remaining code coverage lines"

@schreiberx

Copy link
Copy Markdown
Collaborator Author

@schreiberx One more thing, in the future, instead of commit messages like "intermediate commit" could you write a more informative message, like "Requested Claude Code to cover remaining code coverage lines"

I didn't expect Claude code to work through this on its first attempt and assumed that's an intermediate commit.

@sergisiso sergisiso merged commit c9cfb55 into master Jun 1, 2026
13 of 14 checks passed
@sergisiso sergisiso deleted the martin_coverage branch June 1, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants