(Towards #3449) Support keeping acc routine and omp declare target directives#3451
Merged
Conversation
Collaborator
Author
|
@sergisiso This is ready for a first look. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3451 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 393 393
Lines 55024 55065 +41
=========================================
+ Hits 55024 55065 +41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
arporter
requested changes
Jun 8, 2026
arporter
left a comment
arporter
left a comment
Member
There was a problem hiding this comment.
Looks good Aidan. Just a bit of tidying required and I see the doc build failed - please could you take a look?
I've fired off the ITs in the meantime...
Collaborator
Author
|
@arporter comments addressed, the docs just built straight up this time, not sure why they didn't before? Linkspector is a continuing failure I think not related to this PR. |
arporter
approved these changes
Jun 8, 2026
arporter
left a comment
arporter
left a comment
Member
There was a problem hiding this comment.
All good now, thanks Aidan. ITs were all green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.