Fix empty session cleanup when multiple windows opened in parallel#89
Open
daniel-kurzynski wants to merge 1 commit intomainfrom
Open
Fix empty session cleanup when multiple windows opened in parallel#89daniel-kurzynski wants to merge 1 commit intomainfrom
daniel-kurzynski wants to merge 1 commit intomainfrom
Conversation
Defer session persistence until the first prompt arrives instead of creating sessions immediately in new_session(). This prevents empty sessions from being created when the client opens multiple windows simultaneously but the user only interacts with one. - Add PendingSession struct to hold session config before materialization - Store pending sessions in a HashMap keyed by session ID - Materialize pending sessions on first prompt() call - Add create_session_with_id() to SessionManager for deferred creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defer session persistence until the first prompt arrives instead of creating sessions immediately in new_session(). This prevents empty sessions from being created when the client opens multiple windows simultaneously but the user only interacts with one.