disable api key auth by default#140
Open
zackse wants to merge 2 commits into
Open
Conversation
API key support now defaults to disabled; apps that use it must opt in by setting `disable_api_key_support = false`.
soulcutter
approved these changes
May 7, 2026
Contributor
soulcutter
left a comment
soulcutter
left a comment
There was a problem hiding this comment.
The resulting naming for enabling is unfortunate (double-negative)
oof, that IS awkward.
What was your thinking about release timing? ASAP?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://stitchfix.atlassian.net/browse/DP-4629
Problem
#123 made api key auth support a toggle, but it's still enabled by default. Now that we want to disable it widely, to avoid config changes across many apps, we should update the default configuration to disabled.
Solution
Make
disable_api_key_support = truethe default. The resulting naming for enabling is unfortunate (double-negative), but that should be a rare case.A future release could remove api key support altogether if desired.