Skip to content

ACM-30321 Fix AWS instance type#5778

Open
aswinsuryan wants to merge 1 commit intostolostron:mainfrom
aswinsuryan:fix-aws-instancetype
Open

ACM-30321 Fix AWS instance type#5778
aswinsuryan wants to merge 1 commit intostolostron:mainfrom
aswinsuryan:fix-aws-instancetype

Conversation

@aswinsuryan
Copy link
Contributor

@aswinsuryan aswinsuryan commented Mar 5, 2026

c5d.large is not working so changed to m5.xlarge

📝 Summary

"subctl cloud prepare aws" creates machine that will not be provisioned as node
Ticket Summary (Title):

Ticket Link:
https://issues.redhat.com/browse/ACM-30321

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

  • UI/UX reviewed (if applicable)
  • All acceptance criteria met
  • Unit test coverage added or updated
  • Relevant documentation or comments included

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

🗒️ Notes for Reviewers

Summary by CodeRabbit

  • Chores
    • Updated the default AWS instance type configuration for Submariner gateway nodes across all supported locales.

c5d.large is not working so changed to m5.xlarge

Signed-off-by: Aswin Suryanarayanan <asuryan@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Mar 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aswinsuryan
Once this PR has been reviewed and has the lgtm label, please assign edewit for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

📝 Walkthrough

Walkthrough

Updated the default AWS EC2 instance type for Submariner gateway nodes from c5d.large to m5.xlarge across localization files in English, Spanish, French, Japanese, Korean, and Chinese, as well as in the TypeScript configuration source.

Changes

Cohort / File(s) Summary
Translation Files
frontend/public/locales/en/translation.json, frontend/public/locales/es/translation.json, frontend/public/locales/fr/translation.json, frontend/public/locales/ja/translation.json, frontend/public/locales/ko/translation.json, frontend/public/locales/zh/translation.json
Updated AWS instance type default from c5d.large to m5.xlarge in the Submariner instance type help text across all supported language translations.
Configuration
frontend/src/resources/submariner-config.ts
Updated the default AWS instance type value in submarinerConfigDefault from c5d.large to m5.xlarge.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop, skip, and a type update too,
From c5d to m5 we flew,
Submariner nodes now shine so bright,
Across all tongues, the config's right!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'ACM-30321 Fix AWS instance type' clearly and concisely summarizes the main change of updating the default AWS instance type from c5d.large to m5.xlarge across configuration and translation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description follows the required template structure with all major sections present, including ticket summary, ticket link, type of change, checklist, and notes for reviewers.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant