You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
Hi, thanks for submitting a fix for this issue. job and storageosupgrade CRDs are not maintained for now. When they were added in the operator, operator used to have cluster admin role. Later specific permissions were added and cluster admin requirement was removed. Since job and storageosupgrade CRDs weren't maintained or tested, the permissions required for them have not been added in the operator. We will be adding automated tests and maintain those two CRDs in the coming months.
The fix looks good and it'll work when the operator is deployed using the manifest files. But we also support other means of installing the operator, like using OLM (Operator Lifecycle Manager). For that, can you please add the same change in storageos-operators.configmap.yaml and then run make metadata-update to populate the same change in all the various places it's required?
Also, would be great if you could squash all the commits into a single commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cluster-operator can check the logs after the creation of the job