fix(website): complete HTML attribute escaping in the editor component#279
Merged
Conversation
The per-variant data-tag and data-file attributes were built with esc(), which escapes &<> but not the double quote that delimits the attribute (CodeQL js/incomplete-html-attribute-sanitization). Escape " to " as the adjacent data-copy already does; the sanitization is now complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the two CodeQL
js/incomplete-html-attribute-sanitizationalerts (medium) inwebsite/src/components/tutorial/tutorialTheme.js.The per-variant
data-taganddata-fileattributes on code blocks were built withesc(), which escapes&,<,>but not the"that delimits the attribute. Escape"to", matching the adjacentdata-copyattribute.In practice these values are static (
Kotlin/Java, filenames), so there is no exploitable injection; this completes the sanitization pattern and clears the alerts.