WeightVectorChecker: Fix solver bounds for negative weights#936
Open
tquatmann wants to merge 4 commits into
Open
WeightVectorChecker: Fix solver bounds for negative weights#936tquatmann wants to merge 4 commits into
tquatmann wants to merge 4 commits into
Conversation
sjunges
reviewed
May 26, 2026
| continue; // this objective is not relevant for the weighted sum, so we can skip it | ||
| } else { | ||
| // Choose the requested, relevant bound (lower or upper). Invert the choice for negative weights. | ||
| boost::optional<ValueType> const& objBound = (lower == (weight > storm::utility::zero<ValueType>())) ? this->objectives[objIndex].lowerResultBound |
Contributor
Author
There was a problem hiding this comment.
The bound is already stored as a boost::optional in the Objective class, so we're not introducing a new boost::optional here.
Happy to change all occurrences of boost::optional in a separate PR.
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue when using the WeightVectorChecker with negative weights and sound computations enabled.
Also adds some tests for the WeightVectorChecker.