Add reviewer sop, and update release notes sop #3
+661
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zastrowm
approved these changes
Jan 21, 2026
afarntrog
reviewed
Jan 21, 2026
| - You MAY encounter PRs without conventional commit prefixes | ||
|
|
||
| #### 2.2 Analyze PR Descriptions | ||
| #### 2.2 Analyze PR Descriptions and Review Comments |
There was a problem hiding this comment.
Have we tested a version of this were the agent reads the code instead of reading any human generated descriptions such as the PR "titles, description, comments"? The code is the ultimate source of truth
| age: int | ||
|
|
||
| # BAD: No assertions about behavior | ||
| agent = Agent(model=mock_model, output_schema=UserResponse) |
There was a problem hiding this comment.
agent = Agent(model=mock_model, output_schema=UserResponse) this should be agent = Agent(model=mock_model, structured_output_model=UserResponse)
| **Installing Dependencies:** | ||
| - You MUST attempt to install missing dependencies when tests fail due to import errors | ||
| - You SHOULD check the project's dependency manifest (`pyproject.toml`, `package.json`, `Cargo.toml`, etc.) for optional dependency groups | ||
| - You SHOULD use the project's package manager to install dependencies (e.g., `pip install`, `npm install`, `cargo add`) |
There was a problem hiding this comment.
Consider using uv as an example here as we do
| Description of the feature and its impact. | ||
| MCP Connections via ToolProviders allow the Agent to manage connection lifecycles automatically, eliminating the need for manual context managers. This experimental interface simplifies MCP tool integration significantly. | ||
|
|
||
| \`\`\`python |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reviewer sop, and update release notes sop to match sop in python repo
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.