fix(session): forward session resolution errors as StreamEvent#33
Merged
Conversation
Wrap the resolve_session() call in the invoke() generator with a try/except block so that any exception raised during session resolution (e.g. botocore.exceptions.TokenRetrievalError from expired AWS SSO tokens) is caught, logged via logger.exception(), and forwarded to the client as an error StreamEvent. Previously the exception propagated unhandled, ending the stream abruptly with no error feedback. Closes #32
Copilot
AI
changed the title
[WIP] Fix SSO token expired error not forwarded as StreamEvent
fix(session): forward session resolution errors as StreamEvent
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
resolve_session()raises (e.g.botocore.exceptions.TokenRetrievalErrorfrom expired AWS SSO credentials), the exception previously propagated unhandled out of theinvoke()generator, ending the stream abruptly with no error event emitted to the client.Changes
app.py— wrapresolve_session()intry/except Exception; on failure log vialogger.exception()and yield an errorStreamEventbefore returning.app.state.sessionis only updated on success.test_app_invoke.py— addstest_yields_error_event_when_resolve_session_raisesto assert that a single error event is emitted andapp.state.sessionremainsNonewhen resolution fails.