Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes Doctrine ORM and related dependencies from the project, including the Doctrine Bundle, Migrations Bundle, and Zenstruck Foundry for test fixtures.
Changes:
- Removed Doctrine-related packages from composer.json dependencies
- Deleted all database-related entities, repositories, factories, and migrations
- Removed fixture loading functionality from task runners (Castor and Makefile)
- Cleaned up configuration files for Doctrine and Zenstruck Foundry
Reviewed changes
Copilot reviewed 20 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Removed Doctrine DBAL, ORM, Migrations, and Zenstruck Foundry dependencies |
| config/bundles.php | Removed Doctrine and Foundry bundle registrations |
| config/packages/doctrine.php | Deleted Doctrine ORM/DBAL configuration |
| config/packages/doctrine_migrations.php | Deleted migrations configuration |
| config/packages/zenstruck_foundry.php | Deleted Foundry configuration |
| .env | Removed DATABASE_URL configuration |
| src/Entity/User.php | Deleted User entity with Doctrine mappings |
| src/Repository/UserRepository.php | Deleted Doctrine repository |
| src/Factory/UserFactory.php | Deleted Foundry factory |
| src/Story/AppStory.php | Deleted Foundry story/fixture |
| src/Controller/ListUsersAction.php | Deleted controller that displayed users via DBAL and ORM |
| templates/App/Controller/ListUsersAction.html.twig | Deleted template for users list |
| templates/base.html.twig | Removed navigation link to users list |
| migrations/Version20260117053612.php | Deleted initial database migration |
| tests/Unit/Entity/UserTest.php | Deleted unit tests for User entity |
| tests/Integration/Entity/UserTest.php | Deleted integration tests for User persistence |
| tests/Functional/Controller/ListUsersActionTest.php | Deleted functional tests for users list controller |
| phpunit.xml.dist | Commented out Foundry extension bootstrap |
| castor.php | Removed fixture loading and database reset functions; updated task dependencies |
| Makefile | Removed load-fixtures target and database reset commands; updated task dependencies |
Comments suppressed due to low confidence (1)
migrations/Version20260117053612.php:1
- The migration class name includes a timestamp '20260117053612' which corresponds to January 17, 2026, 05:36:12. Since the current date is January 17, 2026, ensure this timestamp accurately reflects when the migration was generated and is not mistakenly set to a future time.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Remove Doctrine DBAL, ORM, Migrations, and Zenstruck Foundry packages to keep the framework lightweight. This includes: - Removed doctrine-bundle, doctrine-orm, doctrine-dbal, doctrine-migrations-bundle, zenstruck/foundry from composer.json - Removed Doctrine configuration files (doctrine.php, doctrine_migrations.php, zenstruck_foundry.php) - Removed ListUsersAction controller and related Entity, Repository, Factory, Story classes - Removed associated tests and templates - Removed database migration files - Updated Makefile and castor.php to remove Doctrine-related tasks - Updated .env, templates/base.html.twig, and phpunit.xml.dist All tests pass and code coverage remains at 100%.
COil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use this branch if you would rather not use Doctrine.