Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Psalm static analysis tooling to the project alongside the existing PHPStan setup. The changes include configuring Psalm, integrating it into the build pipeline, and making necessary code adjustments to satisfy Psalm's type checking requirements.
Changes:
- Added Psalm configuration and dependency
- Integrated Psalm into CI/CD workflows and build tools (Makefile, Castor, GitHub Actions)
- Modified User entity properties to allow null values for createdAt/updatedAt fields
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| psalm.xml | New Psalm configuration file with project files and issue handlers |
| composer.json | Added vimeo/psalm dependency |
| castor.php | Added psalm() task and integrated it into lint_all(), extracted warmupDevCache() helper |
| Makefile | Added psalm target and integrated into lint command |
| .github/workflows/symfony.yml | Added Psalm static analysis step to CI workflow |
| src/Entity/User.php | Made createdAt and updatedAt properties nullable to satisfy Psalm requirements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
COil
force-pushed
the
psalm
branch
2 times, most recently
from
01204f8 to
a32afbd
Compare
- Add Psalm to composer dependencies - Add psalm configuration file - Add Psalm task to castor and make commands - Add Psalm to GitHub Actions workflow - Add Psalm to CI and lint workflows
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App_KernelDevDebugContainer.xmlcannot be loaded anymore (XmlFileLoaderis gone) psalm/psalm-plugin-symfony#372