Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project dependencies and supporting code to run on Symfony 7.4 LTS (and a lower PHP baseline).
Changes:
- Downgraded Symfony packages from 8.0 to 7.4 and adjusted PHP requirement to >=8.2.
- Refactored
ListUsersActionto delegate data fetching to a dedicated data service returning a DTO, and updated the Twig template accordingly. - Added
eraseCredentials()toUserand exercised it in the unit test; updated internal docs to mention the newData/directory.
Reviewed changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Unit/Entity/UserTest.php | Calls eraseCredentials() during entity test. |
| templates/App/Controller/ListUsersAction.html.twig | Switches view inputs to data.usersDbal / data.usersOrm and updates displayed example code. |
| src/Entity/User.php | Adds eraseCredentials() (with an #[\Override] attribute). |
| src/Data/Controller/ListUsersActionData.php | Introduces data service assembling DBAL + ORM data into a DTO. |
| src/Controller/ListUsersActionDto.php | Introduces DTO for ListUsersAction view data. |
| src/Controller/ListUsersAction.php | Injects data service and renders it as data. |
| composer.json | Downgrades Symfony constraints to 7.4 and lowers PHP requirement to >=8.2. |
| AGENTS.md | Documents the new src/Data/ directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deprecations.logfile.