discover ASIC telemetry by miner's username and port #615
Open
GitGab19 wants to merge 1 commit into
Open
Conversation
GitGab19
changed the title
Member
Author
|
I just tested this on my old macOS, with Docker Desktop, without enabling host networking, and it worked! 
|
GitGab19
force-pushed
the
asic-rs-follow-up
branch
from
481223a to
a114bdd
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Add CIDR-based miner telemetry discovery for tProxy and JDC, expose management IP/status metadata, and match discovered ASICs using the active pool username plus expected Stratum port to avoid false matches across tProxy/JDC. Install CA certificates in Docker images for reqwest-based telemetry requests, and update config examples and docs.
GitGab19
force-pushed
the
asic-rs-follow-up
branch
from
a114bdd to
d0e7d95
Compare
Member
Author
|
Today we were able to test this together on @lucasbalieiro macOS, and it worked as well. This PR is now ready for reviews :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unblocks and fixes the issue we faced while working on stratum-mining/sv2-ui#202
It leverages the discovery feature of
asic-rsto find miners into the configured subnet, and matches them with the clients connected to tProxy and/or JDC by comparing the pool's username returned byasic-rs(and the port) with theauthorized_worker_name(in case of tProxy) and theuser_identityfield (in case of JDC).It also adds some logic to detect duplicated usernames between different miners which might be running under the same subnet.
I still have to fully review the code, but on my end it works inside docker environment as well.
It would be good to get an early test on macOS from @lucasbalieiro 🙏