Add ability to configure coinbase verification in UI#210
Merged
Conversation
Member
|
I think we should keep The application layer already defaults |
GitGab19
force-pushed
the
coinbase-config
branch
from
July 14, 2026 09:07
15869eb to
b6dce07
Compare
Member
|
@pavlenex I force-pushed the changes I requested in the above comment. It would be good to get a final test from you as well. |
Contributor
Author
|
@GitGab19 Works with all the pools tested. I was able to get shares accepted with all but MKPool, but I assume that's probably larger diff on their end and with CPU miner it's just time-consuming. SRI Pool however did a fallback, unsure why, possibly unrelated to the PR itself. |
GitGab19
approved these changes
Jul 14, 2026
GitGab19
left a comment
GitGab19
left a comment
Member
There was a problem hiding this comment.
The issue you reported with SRI pool is not related to anything done on this PR for sure, as logs show that the socket was closed upstream (I don't know why).
So we can proceed with this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Coinbase Verification toggle to Advanced Options for solo pool mining in both setup and Settings. It is enabled by default and controls
verify_payout, allowing miners to turn off the check that their payout address appears in the pool’s coinbase transaction.Before
Always turned on by default
After
Enabled by default, optional to disable