Added Custom Fallback Pool from Settings #217
Open
Ayush4958 wants to merge 2 commits into
Open
Conversation
Contributor
|
Hey @Ayush4958 thanks for the PR. I've tested it and it works. My concern with this one is that it adds yet another different flow for adding a pool. So we'll then have 3 different patterns for user, for us to maintain. I appreciate making this change since it revealed a bigger underlying issue with how we approached things here. I've made a more complex PR #218 on top of yours mostly to credit the efforts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the custom fallback pool from the settings.
Closes #212
Screen Recording
Screen.Recording.2026-07-17.051301.mp4