fix: resolve #1122 — Samsung smart TV support (browser)#1169
Open
ed-thuando wants to merge 3 commits intostreamaserver:masterfrom
Open
Conversation
Fixes streamaserver#1122 Signed-off-by: ed-thuando <231172918+ed-thuando@users.noreply.github.com>
Fixes streamaserver#1122 Signed-off-by: ed-thuando <231172918+ed-thuando@users.noreply.github.com>
Fixes streamaserver#1122 Signed-off-by: ed-thuando <231172918+ed-thuando@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: resolve #1122 — Samsung smart TV support (browser)
Problem
Severity:
High| File:grails-app/assets/javascripts/streama/streama.services.jsCreate a dedicated player cleanup service that handles proper disposal of video resources. Samsung Smart TV browsers need explicit cleanup of video elements, event listeners, and MediaSource buffers. The current implementation likely leaves stale video elements or event handlers that prevent new videos from loading properly.
Solution
Create a $streamaPlayerCleanup service that provides a forceCleanup() method which:
Changes
grails-app/assets/javascripts/streama/streama.services.js(new)grails-app/assets/javascripts/streama/controllers/player-ctrl.js(modified)grails-app/conf/ApplicationResources.groovy(new)Testing
Generated by ContribAI v6.0.0