feat: support oxia metadata store#1276
Conversation
|
@mattisonchao:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
Bot
added
the
doc-info-missing
| imagePullPolicy: {{ .Values.images.oxia.pullPolicy }} | ||
| monitoringEnabled: {{ include "pulsar.oxia.podMonitor.enabled" . }} | ||
| server: | ||
| replicas: 3 |
There was a problem hiding this comment.
Can you make this replicas configurable along with the cpu and memory? Perhaps the minimum number of replicas should be limited to 3
| @@ -1189,6 +1193,8 @@ autorecovery: | |||
| ## metadata deployed | |||
| pulsar_metadata: | |||
| component: pulsar-init | |||
There was a problem hiding this comment.
Just like with other components, how about adding an oxia section to support custom labels, annotations, replicas, CPU, and memory?
| mtls: | ||
| mode: permissive | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
It's missing istio section? https://github.com/streamnative/charts/pull/1276/changes#diff-edcacf5ede6b672523d93711216aa0d8b49a725cea13f4b379fec730f6abd189R183 is it expected?
| trustCertsEnabled: {{ .Values.tls.broker.trustCertsEnabled }} | ||
| {{- end }} | ||
| {{- if and .Values.istio.enabled .Values.ingress.broker.enabled }} | ||
| {{- if .Values.istio.enabled }} |
There was a problem hiding this comment.
This change hasn’t been implemented in sn-platform-slim yet. Please help check it
Motivation
Modifications
pulsar_metadata.providersupport forzookeeperandoxia, with validation for ZooKeeper-only fields.oxiachart values for custom labels, annotations, server replica count, server resources, and coordinator resources.job_name: oxiathat scrapes bothmetricsandcoord-metricsports.monitoringEnabledon the availability of the PodMonitor API so sn-operator only creates PodMonitor when Prometheus Operator CRDs exist.Documentation
values.yaml, andexamples/sn-platform/values-oxia.yamlshows the minimal Oxia enablement path.Testing
helm lint charts/sn-platform-slim -f examples/sn-platform/values-oxia.yaml --set istio.enabled=true --set monitoring.prometheus=true --set monitoring.grafana=falsehelm lint charts/sn-platform -f examples/sn-platform/values-oxia.yaml --set istio.enabled=true --set monitoring.prometheus=true --set monitoring.grafana=falsehelm lintfor the sn-platform and sn-platform-slim CI values.helm templatefor both chart variants with Oxia values.oxia.replicaCount < 3fails template validation for Oxia metadata deployments.oxia_dataserver_*andoxia_coordinator_*series underjob=oxia.