fix: PulsarCluster identity state with create-only fields#150
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves Terraform state handling for create-only identity fields (notably for PulsarCluster) and makes ServiceAccountBinding readiness checks more robust by centralizing condition evaluation.
Changes:
- Add helper functions/tests to consistently evaluate readiness and set identity state.
- Update
ServiceAccountBindingacceptance test to use the new readiness helper and update create flow to wait for readiness. - Ensure
PulsarClusterread path sets create-only identity fields into state to prevent drift, with new unit + acceptance test assertions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
cloud/service_account_binding_test.go |
Replaces inline condition indexing with isServiceAccountBindingReady to avoid fragile condition ordering assumptions. |
cloud/service_account_binding_state_test.go |
Adds unit tests for isServiceAccountBindingReady behavior with/without IAM account creation. |
cloud/resource_service_account_binding.go |
Adds isServiceAccountBindingReady and updates create to retry until the resource is Ready. |
cloud/resource_pulsar_cluster.go |
Adds setPulsarClusterIdentityState and calls it during Read to stabilize state for create-only identity fields. |
cloud/pulsar_cluster_test.go |
Extends acceptance tests to assert identity/create-only fields are correctly reflected in state. |
cloud/pulsar_cluster_state_test.go |
Adds unit tests for setPulsarClusterIdentityState across hosted/BYOC and import scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jiangpengcheng
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.