Skip to content

fix: PulsarCluster identity state with create-only fields#150

Merged
freeznet merged 2 commits intomainfrom
freeznet/cluster-updatable-fields
Mar 27, 2026
Merged

fix: PulsarCluster identity state with create-only fields#150
freeznet merged 2 commits intomainfrom
freeznet/cluster-updatable-fields

Conversation

@freeznet
Copy link
Copy Markdown
Member

No description provided.

@freeznet freeznet self-assigned this Mar 26, 2026
@freeznet freeznet requested a review from a team as a code owner March 26, 2026 03:32
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves Terraform state handling for create-only identity fields (notably for PulsarCluster) and makes ServiceAccountBinding readiness checks more robust by centralizing condition evaluation.

Changes:

  • Add helper functions/tests to consistently evaluate readiness and set identity state.
  • Update ServiceAccountBinding acceptance test to use the new readiness helper and update create flow to wait for readiness.
  • Ensure PulsarCluster read path sets create-only identity fields into state to prevent drift, with new unit + acceptance test assertions.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cloud/service_account_binding_test.go Replaces inline condition indexing with isServiceAccountBindingReady to avoid fragile condition ordering assumptions.
cloud/service_account_binding_state_test.go Adds unit tests for isServiceAccountBindingReady behavior with/without IAM account creation.
cloud/resource_service_account_binding.go Adds isServiceAccountBindingReady and updates create to retry until the resource is Ready.
cloud/resource_pulsar_cluster.go Adds setPulsarClusterIdentityState and calls it during Read to stabilize state for create-only identity fields.
cloud/pulsar_cluster_test.go Extends acceptance tests to assert identity/create-only fields are correctly reflected in state.
cloud/pulsar_cluster_state_test.go Adds unit tests for setPulsarClusterIdentityState across hosted/BYOC and import scenarios.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@freeznet freeznet merged commit 763ca56 into main Mar 27, 2026
5 checks passed
@freeznet freeznet deleted the freeznet/cluster-updatable-fields branch March 27, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants