feat(cloud): add check for maintenance window org-level feature#151
Open
feat(cloud): add check for maintenance window org-level feature#151
Conversation
There was a problem hiding this comment.
Pull request overview
Adds provider-side validation and UX improvements around Pulsar cluster maintenance_window (org-level feature gating) and serverless lakehouse_storage_enabled drift handling.
Changes:
- Add a dry-run create/update validation that errors when
maintenance_windowis silently dropped (feature not enabled for the org). - Refactor maintenance window expand/compare logic into helpers and add unit tests for those helpers.
- Suppress diffs for provider-managed serverless lakehouse storage and add tests + doc clarifications.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/resources/pulsar_cluster.md | Document org-level availability/error behavior for maintenance_window on the resource. |
| docs/data-sources/pulsar_cluster.md | Clarify when maintenance_window is reported by the data source. |
| cloud/resource_pulsar_cluster.go | Implement dry-run maintenance window acceptance check; refactor maintenance window expansion/equality helpers; improve serverless lakehouse diff suppression. |
| cloud/data_source_pulsar_cluster.go | Factor identity-state setting into helper and ensure location is set for the data source. |
| cloud/pulsar_cluster_test.go | Add acceptance test to ensure no plan drift for serverless lakehouse storage. |
| cloud/pulsar_cluster_state_test.go | Add unit tests for data source identity state and maintenance window helpers. |
| cloud/pulsar_cluster_customize_diff_test.go | Add unit test ensuring lakehouse diff is cleared by CustomizeDiff helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.