Skip to content

riseBidAdapter: add meta object support#57

Open
lasloche wants to merge 1 commit into
masterfrom
riseBidAdapter-meta-object-support
Open

riseBidAdapter: add meta object support#57
lasloche wants to merge 1 commit into
masterfrom
riseBidAdapter-meta-object-support

Conversation

@lasloche

Copy link
Copy Markdown

IMPORTANT: the PR is created for internal review, do not merge it!

@codeguard-pr-analyzer

Copy link
Copy Markdown

🤖 CodeGuard PR Analysis

✨ Summary

This PR introduces support for a meta object in the riseBidAdapter bid responses, allowing additional metadata to be passed. A new utility function buildBidMeta is added, and existing bid response building is updated to use it. This PR is for internal review only and should not be merged.

🎯 Jira Ticket Alignment: ℹ️ Not Found

⚠️ Risk Level: 🟡 Medium

This change introduces new bid response data handling logic. The risk is mitigated by the inclusion of dedicated tests for the new functionality, but it affects the core bid response structure.

🧪 Test Coverage

✅ Tests included for new functionality, covering server-side meta fields and adomain fallback logic.

📊 Root Cause Analysis

The changes were made to enhance the riseBidAdapter's capability to include a comprehensive meta object in bid responses, allowing for richer data communication beyond basic bid parameters.

🔗 Dependency Chain
  • Modified:
    • libraries/riseUtils/index.js
    • test/spec/modules/riseBidAdapter_spec.js
  • Impacts: riseBidAdapter's bid response structure and utility functions.
  • Dependencies: None added or removed.
📝 Detailed Changes

New Features:

  • libraries/riseUtils/index.js: Added buildBidMeta function to construct the bid response meta object, supporting both direct meta fields and adomain fallback.

Modified:

  • libraries/riseUtils/index.js: buildBidResponse now utilizes the new buildBidMeta function for constructing the meta object, instead of inline meta object creation.

Tests:

  • test/spec/modules/riseBidAdapter_spec.js: Added new test cases to verify the correct inclusion of meta fields from the server response and the fallback mechanism to adomain for advertiserDomains when meta is absent.

Powered by Gemini 2.5 Flash | Last updated: 23/04/2026 08:53:07 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants