Skip to content

Rise: support the meta object#4

Closed
lasloche wants to merge 1 commit into
masterfrom
rise-support-meta
Closed

Rise: support the meta object#4
lasloche wants to merge 1 commit into
masterfrom
rise-support-meta

Conversation

@lasloche

Copy link
Copy Markdown

IMPORTANT: the PR is created for internal review, do not merge it!

@codeguard-pr-analyzer

codeguard-pr-analyzer Bot commented Apr 23, 2026

Copy link
Copy Markdown

🤖 CodeGuard PR Analysis

✨ Summary

This pull request adds support for the meta object within the Rise bidder adapter, allowing it to parse and pass bid metadata received from the Rise endpoint. This PR is marked for internal review and not to be merged.

🎯 Jira Ticket Alignment: ℹ️ Not Found

⚠️ Risk Level: ⚪ Low

This PR is explicitly marked as "for internal review, do not merge." The changes introduce new functionality with new internal types and a dedicated parsing function, along with new tests, minimizing immediate risk.

🧪 Test Coverage
✅ Tests included for new functionality, with a new integration test case (simple-banner-meta.json) verifying the meta object parsing.

📊 Root Cause Analysis
These changes were made to extend the Rise adapter's capabilities to process and expose the OpenRTB ext.prebid.meta object from bid responses, which contains additional information like advertiser domains and category IDs.

🔗 Dependency Chain

  • Modified: adapters/rise/rise.go, adapters/rise/risetest/exemplary/simple-banner-meta.json
  • Impacts: Rise bidder adapter's bid response processing, Prebid Server's ability to expose Rise bid metadata.
  • Dependencies: openrtb_ext for ExtBidPrebidMeta struct.

📝 Detailed Changes

New Features:

  • adapters/rise/rise.go: Added riseExtBidPrebid and riseExtBid structs for unmarshalling ext.prebid.meta from bid responses.
  • adapters/rise/rise.go: Introduced getBidMeta function to safely parse and return the openrtb_ext.ExtBidPrebidMeta object from bid extensions.
  • adapters/rise/rise.go: Integrated the getBidMeta function into MakeBids to populate BidMeta for adapters.TypedBid.

Modified:

  • adapters/rise/rise.go: MakeBids function updated to include BidMeta when creating adapters.TypedBid objects.

Tests:

  • adapters/rise/risetest/exemplary/simple-banner-meta.json: Added a new integration test case to verify the correct parsing and population of the bidMeta object when present in the bid response.

Powered by Gemini 2.5 Flash | Last updated: 09/06/2026 13:19:45 UTC

@lasloche lasloche force-pushed the rise-support-meta branch from c220798 to 096f67b Compare June 9, 2026 13:19
@lasloche lasloche closed this Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants