Skip to content

Change defualt, expose Browser flag #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giditietz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change defualt, expose Browser flag #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f09fb43
Change defualt, expose Browser flag
giditietz Jan 5, 2020
237156a
Expose DeviceTypeUnidentified const
giditietz Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions udger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@ import (
"strings"
)

const DeviceTypeUnidentified = "Unidentified"

type Flags struct {
browser bool
Browser bool
Device bool
os bool
}
Expand All @@ -19,7 +21,7 @@ type Flags struct {
func New(dbPath string, flags *Flags) (*Udger, error) {
if flags == nil {
flags = &Flags{
browser: true,
Browser: true,
Device: true,
os: true,
}
Expand Down Expand Up @@ -58,7 +60,7 @@ func (udger *Udger) Lookup(ua string) (*Info, error) {
f := udger.Flags

var browserID int
if f.browser {
if f.Browser {
browserID, version, err := udger.findDataWithVersion(ua, udger.rexBrowsers, true)
if err != nil {
return nil, err
Expand Down Expand Up @@ -103,8 +105,8 @@ func (udger *Udger) Lookup(ua string) (*Info, error) {
} else {
//nothing so personal computer
info.Device = Device{
Name: "Personal computer",
Icon: "desktop.png",
Name: DeviceTypeUnidentified,
Icon: "unidentified.png",
}
}
}
Expand Down Expand Up @@ -149,7 +151,7 @@ func (udger *Udger) findData(ua string, data []rexData, withVersion bool) (idx i

func (udger *Udger) init() error {
f := udger.Flags
if f.browser {
if f.Browser {
if err := udger.initBrowsers(); err != nil {
return err
}
Expand Down