Skip to content

RPRS-3045 Cost reduction: win notice and BURL pixel modifications #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
misha93m wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RPRS-3045 Cost reduction: win notice and BURL pixel modifications #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions ad.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,16 @@ func (ad *Ad) AddTrackingEvents(trackingEvents ...Tracking) {
if inline := ad.InLine; inline != nil {
for i := range inline.Creatives {
c := &inline.Creatives[i]

linear := c.Linear
if linear == nil {
continue
if linear != nil {
linear.TrackingEvents = append(linear.TrackingEvents, trackingEvents...)
}

nonLinear := c.NonLinearAds
if nonLinear != nil {
nonLinear.TrackingEvents = append(nonLinear.TrackingEvents, trackingEvents...)
}
linear.TrackingEvents = append(linear.TrackingEvents, trackingEvents...)
}
}
if wrapper := ad.Wrapper; wrapper != nil {
Expand Down Expand Up @@ -170,16 +175,28 @@ func (ad *Ad) AddClickTrackings(clickTrackings ...VideoClick) {
if inline := ad.InLine; inline != nil {
for i := range inline.Creatives {
c := &inline.Creatives[i]

linear := c.Linear
if linear == nil {
continue
if linear != nil {
videoClicks := linear.VideoClicks
if videoClicks == nil {
videoClicks = &VideoClicks{}
linear.VideoClicks = videoClicks
}
videoClicks.ClickTrackings = append(videoClicks.ClickTrackings, clickTrackings...)
}
videoClicks := linear.VideoClicks
if videoClicks == nil {
videoClicks = &VideoClicks{}
linear.VideoClicks = videoClicks

nonLinear := c.NonLinearAds
if nonLinear != nil {
clickTrackingURLs := make([]string, 0, len(clickTrackings))
for _, url := range clickTrackings {
clickTrackingURLs = append(clickTrackingURLs, url.URI)
}

for _, nonLinearAd := range nonLinear.NonLinears {
nonLinearAd.NonLinearClickTracking = append(nonLinearAd.NonLinearClickTracking, clickTrackingURLs...)
}
}
videoClicks.ClickTrackings = append(videoClicks.ClickTrackings, clickTrackings...)
}
}
if wrapper := ad.Wrapper; wrapper != nil {
Expand Down