Fix panic running plugin subcommands with nil context#1708
Open
xheggs wants to merge 1 commit into
Open
Conversation
stripe projects <subcommand> (init, status, catalog, ...) panics with "cannot create context from nil parent": runPluginCmd passes cmd.Context() into withSIGTERMCancel, but the context is nil for plugin subcommand stubs, so context.WithCancel(nil) panics. Default the parent context to context.Background() when nil, mirroring the guard already used on the plugin help path. Fixes stripe#1707
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every executed plugin subcommand under
stripe projects(init,status,catalog,search,add, …) panics withcannot create context from nil parentinstead of running, making the Projects plugin unusable.runPluginCmdpassescmd.Context()intowithSIGTERMCancel, butcmd.Context()isnilfor the dynamically-registered plugin subcommand stubs, socontext.WithCancel(nil)panics under Go 1.15+.The help path in the same file already guards against this with
SetContext(context.Background()); this PR applies the same guard to the execution path.Fixes #1707.
Change
Reproduction
Stack trace:
Testing
v1.42.15(Homebrew) and on a clean build of the tag.stripe projects status/init/catalognow run normally instead of panicking.go build ./...andgofmtclean.Environment