Fix unhandled NumberFormatException in webhook timestamp parsing #2149
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nepomuk5665
requested review from
xavdid-stripe
and removed request for
a team
When parsing the Stripe-Signature header, getTimestamp() calls Long.parseLong() on the timestamp value without catching NumberFormatException. If a malformed header contains a non-numeric timestamp value (e.g., 't=not_a_number'), the exception propagates up uncaught, rather than being wrapped in a SignatureVerificationException as documented. This commit catches NumberFormatException and returns -1, which causes verifyHeader() to throw the expected SignatureVerificationException with the message 'Unable to extract timestamp and signatures from header'. Also adds a test case for malformed timestamp values.
Nepomuk5665
force-pushed
the
fix-webhook-timestamp-parsing-exception
branch
from
bdcd847 to
5ebb98d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an unhandled exception in webhook signature verification when the
Stripe-Signatureheader contains a non-numeric timestamp value.Problem
In
Webhook.Signature.getTimestamp(),Long.parseLong()is called on the timestamp value extracted from the header without exception handling. If a malformed header is received with a non-numeric timestamp (e.g.,t=not_a_number,v1=signature), aNumberFormatExceptionis thrown and propagates up uncaught.This violates the documented contract of
verifyHeader()andconstructEvent(), which state they throwSignatureVerificationExceptionwhen verification fails.Solution
Catch
NumberFormatExceptioningetTimestamp()and return-1, which causesverifyHeader()to throw the expectedSignatureVerificationExceptionwith the message "Unable to extract timestamp and signatures from header".Testing
Added a test case
testMalformedTimestampValue()that verifies the fix by passing a header with a non-numeric timestamp and asserting thatSignatureVerificationExceptionis thrown (notNumberFormatException).