Make Error fields generated#1901
Merged
Merged
Conversation
jar-stripe
reviewed
Jul 10, 2026
jar-stripe
left a comment
jar-stripe
left a comment
Contributor
There was a problem hiding this comment.
This PR should have .rbi file changes as well, right?
Member
Author
|
Weirdly there's no |
Member
Author
|
Ok, missing |
jar-stripe
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Our main API Error class has always been handwritten. As new fields have been added to
api_errorsin the spec over time (e.g.advice_code,network_advice_code,network_decline_code), we haven't picked them up in the SDKs.This makes most of those properties generated so they stay in sync.
What?
See Also