fix(cli): harden run parsing and improve throughput metrics#69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR hardens
stroppy runargument parsing and improves workload/runtime metrics reporting.Main changes:
--.InvalidConfigexit codes.tx_countand active 1stx_tpsbuckets.p1,p5, andp10.Example of the changed report section:
Motivation and Context
The run command accepted several ambiguous argument shapes, especially around mixed positionals, driver/env key-value arguments, and k6 passthrough flags. This made invalid invocations hard to diagnose and could route user intent incorrectly.
The driver/env validation and logging changes make CLI/config behavior more explicit and easier to debug. The TPS metrics add a transaction-oriented throughput view that is separate from k6 iteration rate and query rate, while preserving the existing duration/error metrics.
How Has This Been Tested?
make linter_fixmake lintermake testsmake ts-typecheckgo test -mod=readonly ./...fromcmd/xk6airmake buildgit diff --checkType of Changes
Checklist