Skip to content

Damped sound wave#261

Merged
max-models merged 36 commits into
develfrom
damped-sound-wave
Jun 16, 2026
Merged

Damped sound wave#261
max-models merged 36 commits into
develfrom
damped-sound-wave

Conversation

@spossann

@spossann spossann commented Jun 11, 2026

Copy link
Copy Markdown
Member
  • Move the factor 1/Np into the definition of the weights. This affects sph and accumulation routines; it makes the sph eval kernels easier (no need to differentiate between tesselation and monte-carlo), as all info is in the weights.

  • Fix bug in mpi_sort_markers: add missing self.update_ghost_particles() to get the correct number of valid_mks.

  • Improve unit test for Poisson accumulation.

  • New tutorials and verification tests for SPH:

tutorials/tutorial_viscous_euler_sph.ipynb
tutorials/tutorial_velocity_diffusion_sph.ipynb
tutorials/tutorial_hagen_poiseuille_sph.ipynb
tutorials/tutorial_dam_break_sph.ipynb

Run verif tests for example with (run dam break only with 1 MPI proc):

mpirun -n 2 python src/struphy/models/tests/verification/test_verif_ViscousEulerSPH.py

spossann added 29 commits June 9, 2026 13:34
…This makes the sph eval kernels easier (no need to differentiate betwwen tesselation and monte-carlo), as all info is in the weights.
@spossann

Copy link
Copy Markdown
Member Author

Hi @aminrai2000 - please have a look at the new tutorials in this branch:

tutorials/tutorial_viscous_euler_sph.ipynb
tutorials/tutorial_velocity_diffusion_sph.ipynb
tutorials/tutorial_hagen_poiseuille_sph.ipynb
tutorials/tutorial_dam_break_sph.ipynb

You will find some pictures there that you can modify/use. Alternatively, you can run

mpirun -n 2 python src/struphy/models/tests/verification/test_verif_ViscousEulerSPH.py

to run these tests in parallel and generate these figures (change name ==" main" to switch test). We can discuss on Monday if you want - see you!

@spossann spossann requested a review from aminrai2000 June 14, 2026 15:49
@spossann spossann marked this pull request as ready for review June 15, 2026 06:42
@spossann spossann requested a review from max-models June 15, 2026 06:46
@max-models max-models merged commit ded149c into devel Jun 16, 2026
24 checks passed
@max-models max-models deleted the damped-sound-wave branch June 16, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants