Damped sound wave#261
Merged
Merged
Conversation
…This makes the sph eval kernels easier (no need to differentiate betwwen tesselation and monte-carlo), as all info is in the weights.
Member
Author
|
Hi @aminrai2000 - please have a look at the new tutorials in this branch: You will find some pictures there that you can modify/use. Alternatively, you can run to run these tests in parallel and generate these figures (change name ==" main" to switch test). We can discuss on Monday if you want - see you! |
max-models
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the factor
1/Npinto the definition of the weights. This affects sph and accumulation routines; it makes the sph eval kernels easier (no need to differentiate between tesselation and monte-carlo), as all info is in the weights.Fix bug in
mpi_sort_markers:add missingself.update_ghost_particles()to get the correct number ofvalid_mks.Improve unit test for Poisson accumulation.
New tutorials and verification tests for SPH:
Run verif tests for example with (run dam break only with 1 MPI proc):
New files for sph kernels:
eval_kernels_sph.pyandpusher_kernels_sph.pyNew sections in doc for developerss reference: feec, pic and sph.
Check out the dam break from the new verification test: https://datashare.mpcdf.mpg.de/s/sNYbZZes5GLXKqx
Check out the Hagen-Poiseuille flow from the new verification test: https://datashare.mpcdf.mpg.de/s/9s9mgGLG8yzrZmj