Naming scheme + Adjusted mutation score used by mutation levels#2995
Open
dvcopae wants to merge 11 commits intostryker-mutator:masterfrom
Open
Naming scheme + Adjusted mutation score used by mutation levels#2995dvcopae wants to merge 11 commits intostryker-mutator:masterfrom
dvcopae wants to merge 11 commits intostryker-mutator:masterfrom
Conversation
… because of the mutation level
# Conflicts: # docs/supported-mutators.md
Docs/mutant operator names
dvcopae
changed the title
dvcopae
changed the title
This was referenced Feb 1, 2024
| | ------------------------------------------ | -------------------------------------- | --------------------- | | ||
| | FilledStringLiteralToEmptyReplacement | `"foo"` (filled string) | `""` (empty string) | | ||
| | EmptyStringLiteralToFilledReplacement | `""` (empty string) | `"Stryker was here!"` | | ||
| | FilledInterpolatedStringToEmptyReplacement | `s"foo ${bar}"` (string interpolation) | `s""` ¹ | |
Member
There was a problem hiding this comment.
Minor thing, but as far as I'm concerned, this can also be FilledStringLiteralToEmptyReplacement. I don't think Stryker-JS, for example, has a difference between "" and ``
BundleMon (elements)Files updated (3)
Total files change +523B +0.08% Final result: ✅ View report in BundleMon website ➡️ |
nicojs
reviewed
Mar 1, 2024
| | SubtractionAssignmentNegation | `-=` | `+=` | | ||
| | MultiplicationAssignmentNegation | `*=` | `/=` | | ||
| | DivisionAssignmentNegation | `/=` | `*=` | | ||
| | RemainderAssignmentToMultiplicationReplacement | `%=` | `*=` | |
Member
There was a problem hiding this comment.
Suggested change
| | RemainderAssignmentToMultiplicationReplacement | `%=` | `*=` | | |
| | RemainderAssignmentToMultiplicationAssignmentReplacement | `%=` | `*=` | |
| | RemainderAssignmentToMultiplicationReplacement | `%=` | `*=` | | ||
| | LeftShiftAssignmentNegation | `<<=` | `>>=` | | ||
| | RightShiftAssignmentNegation | `>>=` | `<<=` | | ||
| | BitwiseAndAssignmentToBitwiseOrReplacement | `&=` | <code>|=</code> | |
Member
There was a problem hiding this comment.
Suggested change
| | BitwiseAndAssignmentToBitwiseOrReplacement | `&=` | <code>|=</code> | | |
| | BitwiseAndAssignmentToBitwiseOrAssignmentReplacement | `&=` | <code>|=</code> | |
| | LeftShiftAssignmentNegation | `<<=` | `>>=` | | ||
| | RightShiftAssignmentNegation | `>>=` | `<<=` | | ||
| | BitwiseAndAssignmentToBitwiseOrReplacement | `&=` | <code>|=</code> | | ||
| | BitwiseOrAssignmentToBitwiseAndReplacement | <code>|=</code> | `&=` | |
Member
There was a problem hiding this comment.
Suggested change
| | BitwiseOrAssignmentToBitwiseAndReplacement | <code>|=</code> | `&=` | | |
| | BitwiseOrAssignmentToBitwiseAndAssignmentReplacement | <code>|=</code> | `&=` | |
| | RightShiftAssignmentNegation | `>>=` | `<<=` | | ||
| | BitwiseAndAssignmentToBitwiseOrReplacement | `&=` | <code>|=</code> | | ||
| | BitwiseOrAssignmentToBitwiseAndReplacement | <code>|=</code> | `&=` | | ||
| | NullishCoalescingOperatorToLogicalAndAssignmentReplacement | `??=` | `&&=`¹ | |
Member
There was a problem hiding this comment.
Suggested change
| | NullishCoalescingOperatorToLogicalAndAssignmentReplacement | `??=` | `&&=`¹ | | |
| | NullishCoalescingAssignmentToLogicalAndAssignmentReplacement | `??=` | `&&=`¹ | |
Member
There was a problem hiding this comment.
@rouke-broersma would you agree on this name? Or should it be NullCoalescingAssingmentToLogicalAndAssignmentReplacement?
Comment on lines
+113
to
+122
| | Mutant operator | Original | Mutated | | ||
| | -------------------------------------- | ---------------------------------------------------------- | ------------------------------------------- | | ||
| | ForLoopConditionToFalseReplacement | `for (var i = 0; i < 10; i++) { }` | `for (var i = 0; false; i++) { }` ¹ | | ||
| | WhileLoopConditionToFalseReplacement | `while (a > b) { }` | `while (false) { }` | | ||
| | DoWhileLoopConditionToFalseReplacement | `do { } while (a > b);` | `do { } while (false);` | | ||
| | IfConditionToTrueReplacement | `if (a > b) { }` | `if (true) { }` | | ||
| | IfConditionToFalseReplacement | `if (a > b) { }` | `if (false) { }` | | ||
| | BooleanExpressionToTrueReplacement | `var x = a > b ? 1 : 2;` | `var x = true ? 1 : 2;` ¹ | | ||
| | BooleanExpressionToFalseReplacement | `var x = a > b ? 1 : 2;` | `var x = false ? 1 : 2;` ¹ | | ||
| | SwitchStatementBodyRemoval | `switch(x) { case 1: doSomething(); default: default(); }` | `switch(x) { case 1: default: default(); }` | |
Member
There was a problem hiding this comment.
I think we should remove this group, as mutants in this group should be merged in others.
| Old name | New name |
|---|---|
| ForLoopConditionToFalseReplacement | LessThanExpressionToFalseReplacement |
| WhileLoopConditionToFalseReplacement | same |
| DoWhileLoopConditionToFalseReplacement | GreaterThanExpressionToFalseReplacement |
| IfConditionToTrueReplacement | GreaterThanExpressionToTrueReplacement |
| IfConditionToFalseReplacement | Sane |
| BooleanExpressionToTrueReplacement | Same |
| BooleanExpressionToFalseReplacement | Same |
| SwitchStatementBodyRemoval | BlockStatementRemoval |
Member
|
@nicojs this was replaced with another PR right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains:
The status
IGNORED_BY_LEVEL_STATUSis introduced in the mutation levels PR from StrykerJS, so that one needs to be merged first for this functionality to be enabled.